Skip to content

feat: add blas/ext/base/ndarray/sfill#9094

Open
Amansingh0807 wants to merge 6 commits intostdlib-js:developfrom
Amansingh0807:feat-ndarray-sfill
Open

feat: add blas/ext/base/ndarray/sfill#9094
Amansingh0807 wants to merge 6 commits intostdlib-js:developfrom
Amansingh0807:feat-ndarray-sfill

Conversation

@Amansingh0807
Copy link
Copy Markdown
Contributor

@Amansingh0807 Amansingh0807 commented Dec 16, 2025 •
edited
Loading

type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:

  • task: lint_filenames status: passed
  • task: lint_editorconfig status: passed
  • task: lint_markdown status: passed
  • task: lint_package_json status: passed
  • task: lint_repl_help status: passed
  • task: lint_javascript_src status: passed
  • task: lint_javascript_cli status: na
  • task: lint_javascript_examples status: passed
  • task: lint_javascript_tests status: passed
  • task: lint_python status: na
  • task: lint_r status: na
  • task: lint_c_src status: na
  • task: lint_c_examples status: na
  • task: lint_c_benchmarks status: na
  • task: lint_c_tests_fixtures status: na
  • task: lint_shell status: na
  • task: lint_typescript_declarations status: passed
  • task: lint_typescript_tests status: passed
  • task: lint_license_headers status: passed

Resolves None.

Description

What is the purpose of this pull request?

This pull request:

  • add blas/ext/base/ndarray/sfill

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

  • Resolves None

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). Needs Review A pull request which needs code review. labels Dec 16, 2025
@stdlib-bot
Copy link
Copy Markdown
Contributor

stdlib-bot commented Dec 16, 2025 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
blas/ext/base/ndarray/sfill $\color{green}124/124$
$\color{green}+0.00%$ 		$\color{green}3/3$
$\color{green}+0.00%$ 		$\color{green}1/1$
$\color{green}+0.00%$ 		$\color{green}124/124$
$\color{green}+0.00%$

The above coverage report was generated for the changes in this PR.

@kgryte kgryte added Needs Changes Pull request which needs changes before being merged. Feature Issue or pull request for adding a new feature. and removed Needs Review A pull request which needs code review. labels Dec 20, 2025
@Amansingh0807
Copy link
Copy Markdown
Contributor Author

Amansingh0807 commented Dec 21, 2025 •
edited
Loading

Thanks @kgryte.

I have applied all the requested changes. The review really gave me a much clearer understanding of the architectural patterns and the 'why' behind them.

I have updated this PR and propagated the same standards to all my related PRs (eg : sapx, gapx and etc.) as well. Ready for review.

P.S. I am aware of RFC #8647 regarding string interpolation. For now, I stuck to the dsorthp pattern (concatenation), but let me know if you would prefer I migrate these benchmarks to use @stdlib/string/format in this PR and related ones.

@kgryte
Copy link
Copy Markdown
Member

kgryte commented Dec 21, 2025

@Amansingh0807 I suggest going ahead and using @stdlib/string/format, in order to save ourselves future work. :)

@Amansingh0807
Copy link
Copy Markdown
Contributor Author

Amansingh0807 commented Dec 22, 2025 •
edited
Loading

Acknowledged, thanks @kgryte.

I’ve migrated the benchmarks to use @stdlib/string/format across this PR and related ones.

@kgryte kgryte added Needs Discussion Needs further discussion. status: Blocked Issue or pull request which is currently blocked. labels Jan 14, 2026
@Amansingh0807 Amansingh0807 mentioned this pull request Mar 29, 2026
Open
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). Feature Issue or pull request for adding a new feature. Needs Changes Pull request which needs changes before being merged. Needs Discussion Needs further discussion. status: Blocked Issue or pull request which is currently blocked.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Amansingh0807 @stdlib-bot @kgryte